Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for queue specific visibility time out configuration #264

Closed
wants to merge 1 commit into from

Conversation

qhenkart
Copy link
Contributor

Currently there can only be a single VisibilityTimeout configuration that affects all queues. However in real life situations, some queues process more complex data than others requiring queue specific VisibilityTimeout settings. This PR simply updates the configuration so that queue specific visibility timeouts are also accepted

@Admiral-Piett
Copy link
Owner

@qhenkart This looks awesome, thank you! I will merge it shortly to be in the next release.

@Admiral-Piett
Copy link
Owner

@qhenkart I had to make some updates lately - would you mind rebasing this (so git can track the commit back to you and show your fine work 😉 )?

If you don't want, feel free to have a look at this? I rebased here - #280.

@qhenkart
Copy link
Contributor Author

@Admiral-Piett thank you! I will do it right away

@qhenkart
Copy link
Contributor Author

@Admiral-Piett are you using an alternative to Gofmt? I'm seeing a lot of inconsistent spacing and unusual amount of auto format changes in the rebased PR

@Admiral-Piett
Copy link
Owner

@qhenkart No I'm not, but I am reformatting lots of files as I go. I think it will work itself out eventually, though I know it's an irritant to look at when you're reviewing.

Also, I'm going to close this. I'm sorry - I didn't notice your response until I after I merged this one - #280. It should have been just a rebase of yours anyway. If there's anything I missed or anything I misrepresented let's talk?

@Admiral-Piett
Copy link
Owner

This was rebased and merged in an alternate PR: #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants